patching file mm/mmap.c fails for kernel 6.11.3 #47
Comments
|
vladns:
patching file mm/mmap.c
Hunk #7 FAILED at 3200.
Hunk #8 succeeded at 3558 (offset 4 lines).
Hunk #9 succeeded at 3572 (offset 4 lines).
1 out of 9 hunks FAILED -- saving rejects to file mm/mmap.c.rej
Thanks for the report.
I guess this issue is same to PB's v6.11.2.
Try aufs6.11.2 branch.
J. R. Okajima
|
|
Thanks, but there are still errors: |
|
vladns:
Thanks, but there are still errors:
:::
fs/aufs/hfsnotify.c:36:9: error: implicit declaration of function =E2=80=98=
au_cache_free_hnotify=E2=80=99; did you mean =E2=80=98au_cache_free_vdir=E2=
=80=99? [-Wimplicit-function-declaration]
36 | au_cache_free_hnotify(hn);
| ^~~~~~~~~~~~~~~~~~~~~
| au_cache_free_vdir
fs/aufs/hfsnotify.c: In function =E2=80=98au_hfsn_alloc=E2=80=99:
fs/aufs/hfsnotify.c:51:20: error: =E2=80=98struct au_hinode=E2=80=99 has =
no member named =E2=80=98hi_notify=E2=80=99
51 | hn =3D hinode->hi_notify;
| ^~
I'm afraid your kconfig is corrupted.
How did you set
CONFIG_AUFS_HNOTIFY
or
CONFIG_AUFS_HFSNOTIFY
?
|
|
In my config, there is only one setting, concerning aufs CONFIG_AUFS_FS=m. It is entered via a script, into the original config file. |
|
vladns:
In my config, there is only one setting, concerning aufs CONFIG_AUFS_FS=m. It is entered via a script, into the original config file.
??
I don't understand why your build system compiled fs/aufs/hfsnotify.c.
In fs/aufs/Makefile, the file is described as
aufs-$(CONFIG_AUFS_HFSNOTIFY) += hfsnotify.o
which means hfsnotify.c is compiled only when CONFIG_AUFS_HFSNOTIFY is
enabled. Who and how is it enabled?
J. R. Okajima
|
|
I confirm kernel |
|
Where should this CONFIG_AUFS_HFSNOTIFY setting be? |
|
I found with kernel 6.11.2 as well as 6.11.4, that CONFIG_AUFS_HFSNOTIFY=y must be enabled in the kernel config. If it is disabled, the patches apply well, but I get the same errors as vladns. This is using aufs6-6.11.2 patchset. With CONFIG_AUFS_HFSNOTIFY=y, the kernel builds and boots properly. |
|
roadie2:
I found with kernel 6.11.2 as well as 6.11.4, that CONFIG_AUFS_HFSNOTIFY=y must be enabled in the kernel config. If it is disabled, the patches apply well, but I get the same errors as vladns. This is using aufs6-6.11.2 patchset.
How do you configure?
If you disable CONFIG_AUFS_HFSNOTIFY, then you need to disable
CONFIG_AUFS_HNOTIFY too. Such compile error should not happen.
J. R. Okajima
|
|
vladns:
Where should this CONFIG_AUFS_HFSNOTIFY setting be?
Where do you enable CONFIG_AUFS_FS? The place should be same.
J. R. Okajima
|
|
@sfjro, do you mind explaining to us is what is the benefit of enabling |
|
fulalas:
@sfjro, do you mind explaining to us is what is the benefit of enabling `CONFIG_AUFS_HNOTIFY` and `CONFIG_AUFS_HFSNOTIFY`?
Isn't good enough ro read fs/aufs/Kconfig and aufs manual in
aufs-util.git?
J. R. Okajima
|
|
Maybe, but I don't have the links. I couldn't find anything here: https://aufs.sourceforge.net/aufs6/man.html |
|
fulalas:
Maybe, but I don't have the links. I couldn't find anything here: https://aufs.sourceforge.net/aufs6/man.html
Anything?
Do you mean you got HTTP 404? Or do you mean you couldn't find the
description of CONFIG_ brabra? Didn't fs/aufs/Kconfig help you?
J. R. Okajima
|
|
Do you have any URL or could you provide the explanation to both Thanks! |
|
fulalas:
Do you have any URL or could you provide the explanation to both `CONFIG_AUFS_HNOTIFY` and `CONFIG_AUFS_HFSNOTIFY`?
Before you repeate the same thing, you should answer what I have asked.
…----------------------------------------
Isn't good enough ro read fs/aufs/Kconfig and aufs manual in
aufs-util.git?
----------------------------------------
Anything?
Do you mean you got HTTP 404? Or do you mean you couldn't find the
description of CONFIG_ brabra? Didn't fs/aufs/Kconfig help you?
----------------------------------------
J. R. Okajima
|
|
It's not a 404 -- the link opens but I couldn't find anything useful regarding these 2 things, even outside the link (i.e. google). It looks like you also can't find anything specific, but that's OK. I was just curious. :) |
|
fulalas:
It's not a 404 -- the link opens but I couldn't find anything useful regarding these 2 things, even outside the link (i.e. google).
It looks like you also can't find anything specific, but that's OK. I was just curious. :)
I hope you would understand them after reading fs/aufs/Kconfig, and find
what you want in aufs manual.
J. R. Okajima
|
|
Sorry, no link, no progress. Edit: found it: aufs-standalone/fs/aufs/Kconfig Line 55 in fa57952 |
|
If I don't explicitly change these settings, what are their default values? |
|
vladns:
If I don't explicitly change these settings, what are their default values?
Once you read fs/aufs/Kconfig, you would know there is no default value
for them. It means "no" or "" (empty). It is recommended to read and
understand about the configuration.
J. R. Okajima
|
|
Unfortunately, I am not an expert and I do not understand much. I just follow the instructions. I have never changed these values. The last kernel that built normally for me was 6.10.10. Then my archlinux switched to 6.11.2, after that the problems began. |
This doesn't help me, the error is the same. |
|
vladns:
Unfortunately, I am not an expert and I do not understand much. I just follow the instructions. I have never changed these values. The last kernel that built normally for me was 6.10.10. Then my archlinux switched to 6.11.2, after that the problems began.
What is "the problems" you call here? Compile error in
fs/aufs/hfsnotify.c?
fs/aufs/hfsnotify.c: In function =E2=80=98au_hfsn_free_mark=E2=80=99:
./include/linux/container_of.h:20:54: error: =E2=80=98struct au_hnotify=E2=
=80=99 has no member named =E2=80=98hn_mark=E2=80=99
20 | static_assert(__same_type(*(ptr), ((type *)0)->member) ||=
\
...
What is "the instructions" you call here?
J. R. Okajima
|
Yes.
From the readme, here it is: and so on. |
|
vladns:
My build is successful if I explicitly specify "CONFIG_AUFS_HFSNOTIFY=y" and "CONFIG_AUFS_HNOTIFY=y" in the linux config file.
And you want to disable them, right?
How is your .config after you disable them? Try "fgrep _AUFS_ .config".
J. R. Okajima
|
Yes, I turned it off, the same errors occurred. Here "CONFIG_AUFS_HFSNOTIFY=n" and "CONFIG_AUFS_HNOTIFY=n" in config, although I see that CONFIG_AUFS_HFSNOTIFY=y. |
|
vladns:
Yes, I turned it off, the same errors occurred.
:::
# CONFIG_AUFS_HNOTIFY is not set
CONFIG_AUFS_HFSNOTIFY=y
:::
Now I see the configuration is wrong.
Hmm, linux-v6.11-rc1 seems got changed.
Try this patch plz.
J. R. Okajima
diff --git a/fs/aufs/Kconfig b/fs/aufs/Kconfig
index a5008b87a55f..f6434a7da911 100644
--- a/fs/aufs/Kconfig
+++ b/fs/aufs/Kconfig
@@ -62,13 +62,15 @@ config AUFS_HNOTIFY
It will have a negative impact to the performance.
See detail in aufs.5.
+if AUFS_HNOTIFY
choice
- prompt "method" if AUFS_HNOTIFY
+ prompt "method"
default AUFS_HFSNOTIFY
config AUFS_HFSNOTIFY
bool "fsnotify"
select FSNOTIFY
endchoice
+endif
config AUFS_EXPORT
bool "NFS-exportable aufs"
|
|
Yes, the kernel build is successful. |
|
vladns:
Yes, the kernel build is successful.
Thanks for the test.
The patch will be included in next release.
J. R. Okajima
|
The text was updated successfully, but these errors were encountered: