From d33e71c68202312941d31ad5725cfc0a632015f4 Mon Sep 17 00:00:00 2001 From: Anirudh Hegde Date: Thu, 15 Feb 2024 08:00:14 +0530 Subject: [PATCH] chore(internet_port): added new ports and removed unnecessary string class (#27078) --- superset/advanced_data_type/plugins/internet_port.py | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/superset/advanced_data_type/plugins/internet_port.py b/superset/advanced_data_type/plugins/internet_port.py index 6776c7d0d2e04..3b2f8da7bbdfd 100644 --- a/superset/advanced_data_type/plugins/internet_port.py +++ b/superset/advanced_data_type/plugins/internet_port.py @@ -48,6 +48,11 @@ "ldaps": [636], "imap2": [143], # aka imap "imaps": [993], + "MySQL": [3306], + "Remote Desktop": [3389], + "dns": [53], + "ctf": [84], + "pdap": [344], } @@ -83,9 +88,9 @@ def port_translation_func(req: AdvancedDataTypeRequest) -> AdvancedDataTypeRespo else port_conversion_dict[string_value] ) except (KeyError, ValueError): - resp["error_message"] = str( - f"'{string_value}' does not appear to be a port name or number" - ) + resp[ + "error_message" + ] = f"'{string_value}' does not appear to be a port name or number" break else: resp["display_value"] = ", ".join(