Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fog blending/banding issues #76

Closed
Flecked42 opened this issue Aug 21, 2023 · 8 comments
Closed

Fog blending/banding issues #76

Flecked42 opened this issue Aug 21, 2023 · 8 comments

Comments

@Flecked42
Copy link

Flecked42 commented Aug 21, 2023

QuakeSpasm

spasm0000

Ironwail

w1m7_2023-08-21_13-58-27

I cranked gamma/contrast to max to see it better.

Map is w1m7 from SMEJ https://www.quaddicted.com/filebase/smej_1.13.zip

@sezero
Copy link
Owner

sezero commented Aug 21, 2023

If it's restricted to that map only, then it's minor. Unless someone has a well-tested patch for it..

In any case, is the issue present in latest release (0.95.1), or is it a regression in git?

@sezero
Copy link
Owner

sezero commented Aug 21, 2023

CC: @ericwa, @andrei-drexler

@Flecked42
Copy link
Author

Flecked42 commented Aug 21, 2023

I used the latest release 0.95.1

the banding would happen in many maps with fog

spasm0000

@Flecked42
Copy link
Author

Novum mentioned something about using a "10bit color buffer" #47 (comment)

@sezero
Copy link
Owner

sezero commented Aug 21, 2023

If you or others have a well-tested patch, I'd review and apply it. Otherwise, this will stay as is.

@Flecked42 Flecked42 changed the title Fog blending issues Fog blending/banding issues Aug 21, 2023
@andrei-drexler
Copy link
Contributor

The map uses a grey fog with a value of 0.01, so in an 8-bit framebuffer there are basically at most 4 distinct color values between black and full-intensity fog (inclusively). Cranking up the gamma/contrast only makes things worse. A 10-bit framebuffer would indeed help, but there would still be significant banding with these exaggerated gamma/contrast settings. Besides the 10-bit framebuffer IW also adds a microscopic amount of dithering to all the shaders specifically to avoid banding, but I think that might be a bit overkill for QS.

@Flecked42
Copy link
Author

Flecked42 commented Aug 21, 2023

Thanks for the info. Yea the gamma/contrast was way exaggerated just to show it better.

@sezero
Copy link
Owner

sezero commented Aug 21, 2023

OK then. Closing as WONTFIX.

@sezero sezero closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants