brandingBannerDisplayText Not Respected

[seaneldridge7]

Before submitting a Setup Your Mac bug report, please review the open swiftDialog issues to help determine the source of the issue.

Describe the bug
Despite having brandingBannerDisplayText="false" the text still appears over the top of a custom branding banner.

To Reproduce

• Download a fresh copy of the script, add a custom image to line 109 and set line 110 to false.

Expected behavior
I wouldn't expect to see anything other than the custom branding bannner

Code/log output
brandingBanner="/Users/Shared/Resources/Wallpapers/custom.png" brandingBannerDisplayText="false"

Screenshots

Environment (please complete the following information):

• 14.3
• 1.12.10 & 1.14.0

Additional context
This problem manifested itself at the same time as the update to swiftDialog 2.4.1

[drtaru]

Hi @seaneldridge7,
Are you using the WelcomeDialog to collect userInput?
If yes, does the banner display correctly there, with no text?

[seaneldridge7]

Hi @seaneldridge7, Are you using the WelcomeDialog to collect userInput? If yes, does the banner display correctly there, with no text?

Hi @drtaru, no we're not using that in our workflow. However, if I take a fresh copy of the script and only modify those two lines with a custom banner and set the text to false, the same problem occurs at the userInput screen.

[drtaru]

Perfect, thanks, that helps me narrow it down.
I will dig in!

[drtaru]

Found the issue, seems like if bannerText is set to nothing "" then the title parameter takes over
The fix is to set bannerText=" " instead of bannerText="" when brandingBannerDisplayText="false"
PR #140 should fix this, you can wait for it to be merged or test the changes yourself now.

[dan-snelson]

This should have been closed back in February.