Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store heartbeat use redis setex with wrong timeunit #1610

Closed
AYue-94 opened this issue Sep 1, 2024 · 3 comments · Fixed by #1611
Closed

store heartbeat use redis setex with wrong timeunit #1610

AYue-94 opened this issue Sep 1, 2024 · 3 comments · Fixed by #1611
Labels
kind/bug Something isn't working
Milestone

Comments

@AYue-94
Copy link

AYue-94 commented Sep 1, 2024

What happened?

max.effective.time=60000, the time unit is milliseconds.
image
when store heartbeat use redis setex command, directly set ttl as 60000 seconds.
image

How can we reproduce it (as minimally and precisely as possible)?

just start an agent to send heartbeat.

Anything else we need to know?

No response

Sermant version

2.0.0

OS version

MacOS 14.1

@AYue-94 AYue-94 added the kind/bug Something isn't working label Sep 1, 2024
@AYue-94
Copy link
Author

AYue-94 commented Sep 1, 2024

i will try to fix it

@AYue-94 AYue-94 changed the title store heartbeat use redis setnx with wrong timeunit store heartbeat use redis setex with wrong timeunit Sep 1, 2024
@lilai23
Copy link
Collaborator

lilai23 commented Sep 5, 2024

i will try to fix it

Thanks for find and fix this issue

@lilai23
Copy link
Collaborator

lilai23 commented Sep 5, 2024

@AYue-94 I have found you are not in our contributers now. Confirm your email of GitHub account is the same as your
email when you commit your codes. It may happen for this reason

@lilai23 lilai23 added this to the v2.1.0 milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants