Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nacos dynamic configuration has some problems in the code logic #1584

Closed
daizhenyu opened this issue Jul 26, 2024 · 0 comments · Fixed by #1585
Closed

Nacos dynamic configuration has some problems in the code logic #1584

daizhenyu opened this issue Jul 26, 2024 · 0 comments · Fixed by #1585
Labels
kind/bug Something isn't working kind/enhancement Issues or PRs releated to sermant enhancement
Milestone
v2.1.0

Comments

@daizhenyu
Copy link
Collaborator

daizhenyu commented Jul 26, 2024 •
edited
Loading

What would you like to be enhanced?

The code logic for dynamic configuration of nacos needs to be optimized.

Why is this needed?

Nacos dynamic configuration has some problems in the code logic：

  1. The user name is encrypted.
  2. Nocos token expires early
  3. The HTTP request does not check the status code.
@daizhenyu daizhenyu added kind/bug Something isn't working kind/enhancement Issues or PRs releated to sermant enhancement labels Jul 26, 2024
@daizhenyu daizhenyu mentioned this issue Jul 26, 2024
Merged
3 tasks
@lilai23 lilai23 added this to the v2.1.0 milestone Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working kind/enhancement Issues or PRs releated to sermant enhancement
Projects
None yet
Milestone
v2.1.0
Development

Successfully merging a pull request may close this issue.

dynamic config optimization daizhenyu/Sermant
2 participants
@lilai23 @daizhenyu