Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: replace pdm-backends with setuptools and setuptools-scm #580

Merged
merged 6 commits into from
May 23, 2024

Conversation

huxuan
Copy link
Member

@huxuan huxuan commented May 23, 2024

Prefer setuptools since it supports C extension natively. I just realize that pdm-backend supports C extension by leverage setuptools. :-(

Test workflow:


📚 Documentation preview 📚: https://ss-python--580.org.readthedocs.build/en/580/

@huxuan huxuan changed the title uild: replace pdm-backends with setuptools and setuptools-scm build: replace pdm-backends with setuptools and setuptools-scm May 23, 2024
@huxuan huxuan marked this pull request as ready for review May 23, 2024 09:51
@huxuan huxuan requested a review from msclock May 23, 2024 09:56
@huxuan huxuan enabled auto-merge (squash) May 23, 2024 09:56
@huxuan huxuan removed the request for review from msclock May 23, 2024 10:01
@huxuan huxuan marked this pull request as draft May 23, 2024 10:01
auto-merge was automatically disabled May 23, 2024 10:01

Pull request was converted to draft

@huxuan huxuan marked this pull request as ready for review May 23, 2024 10:04
@huxuan huxuan requested a review from msclock May 23, 2024 10:04
@msclock
Copy link
Contributor

msclock commented May 23, 2024

Seems it is possible to use scikit-build-core as build-backend and pdm to support pybind11 build extensions.

@huxuan
Copy link
Member Author

huxuan commented May 23, 2024

Seems it is possible to use scikit-build-core as build-backend and pdm to support pybind11 build extensions.

I have not use scikit-build-core before, so you mean we should use that instead, right?

@msclock
Copy link
Contributor

msclock commented May 23, 2024

use that instead

@huxuan No, I just consider ss-pybind11 could combine pdm and scikit-build-core👀.

@huxuan huxuan merged commit 79d8c1b into serious-scaffold:main May 23, 2024
19 checks passed
@huxuan huxuan deleted the xuan.hu/setuptools branch May 23, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants