build: default CMAKE_COMPILE_WARNING_AS_ERROR as false #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #180 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 43 43
Branches 7 7
=========================================
Hits 43 43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
msclock
force-pushed
the
warning_as_error_disable
branch
3 times, most recently
from
338cd3c
to
976aa16
Compare
Because it will add -Werror or /WX to compile flags, and it is not suitable for distribution build. Signed-off-by: msclock <msclock@qq.com>
msclock
force-pushed
the
warning_as_error_disable
branch
2 times, most recently
from
c566736
to
e53cf87
Compare
|
🎉 This PR is included in version 1.4.17 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it will add
-Werroror/WXto compile flags, and it is not suitable for distribution build.See https://best.openssf.org/Compiler-Hardening-Guides/Compiler-Options-Hardening-Guide-for-C-and-C++.html#tldr-what-compiler-options-should-i-use