Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: warn compiling targets #166

Merged
merged 2 commits into from
Mar 31, 2024
Merged

Conversation

msclock
Copy link
Collaborator

@msclock msclock commented Mar 31, 2024

Related #164

Signed-off-by: msclock <msclock@qq.com>
Signed-off-by: msclock <msclock@qq.com>
Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (53ada3d) to head (e7eb8ff).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #166   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines           43        43           
  Branches         6         6           
=========================================
  Hits            43        43           
Flag Coverage Δ
x64-linux-gcc-11 100.00% <ø> (ø)
x64-linux-gcc-11-vcpkg 100.00% <ø> (ø)
x64-linux-llvm-vcpkg 100.00% <ø> (ø)
x64-mingw-dynamic-linux-mingw-vcpkg 80.64% <ø> (ø)
x64-mingw-dynamic-windows-mingw-vcpkg ?
x64-osx-applellvm-vcpkg 100.00% <ø> (ø)
x64-osx-llvm-vcpkg 100.00% <ø> (ø)
x64-windows-llvm-vcpkg 100.00% <ø> (ø)
x64-windows-msvc-vcpkg 100.00% <ø> (ø)
x64-windows-msvc-vcpkg-export 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msclock
Copy link
Collaborator Author

msclock commented Mar 31, 2024

It seems mingw on ubuntu implies to use -Werror.

@msclock msclock merged commit 277c8a7 into serious-scaffold:master Mar 31, 2024
17 checks passed
@msclock msclock deleted the compiler_flags branch March 31, 2024 10:10
@serious-scaffold
Copy link
Contributor

🎉 This PR is included in version 1.4.15 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@msclock
Copy link
Collaborator Author

msclock commented Apr 4, 2024

It seems mingw on ubuntu implies to use -Werror.

Finally, I found the present of -Werror is the use of CMAKE_COMPILE_WARNING_AS_ERROR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant