Reset sequence for exceptions is written on next line

[matkoch]

Hopefully, this is not my own fault in some way, but it does appear that reset sequences for the exception message and following stacktraces are written on the next line, instead at the end of the current line. To illustrate the issue:

This also results in the situation that ::endgroup:: is not recognized by GitHubActions, since it's prefixed with the reset sequence.

My guess is that this here:

serilog-sinks-console/src/Serilog.Sinks.Console/Sinks/SystemConsole/Output/ExceptionTokenRenderer.cs

Lines 42 to 48 in 7ecfd08

	while ((nextLine = lines.ReadLine()) != null)
	{
	var style = nextLine.StartsWith(StackFrameLinePrefix) ? ConsoleThemeStyle.SecondaryText : ConsoleThemeStyle.Text;
	var _ = 0;
	using (_theme.Apply(output, style, ref _))
	output.WriteLine(nextLine);
	}

Should rather be:

while ((nextLine = lines.ReadLine()) != null)
{
    var style = nextLine.StartsWith(StackFrameLinePrefix) ? ConsoleThemeStyle.SecondaryText : ConsoleThemeStyle.Text;
    var _ = 0;
    using (_theme.Apply(output, style, ref _))
        output.Write(nextLine);
    output.WriteLine();
}

It doesn't break any tests. Let me know if you agree and want a PR.

[nblumhardt]

Makes sense - thanks for tracking it down 👍

[matkoch]

idk why I closed this :/