Skip to content
This repository has been archived by the owner on Jun 1, 2024. It is now read-only.

Durability feature depends on RollingFile sink which is now a part of the File sink #146

Closed
tafs7 opened this issue Jan 18, 2018 · 2 comments
Labels

Comments

@tafs7
Copy link

tafs7 commented Jan 18, 2018

Are there any plans to change the dependency away from the RollingFile sink and towards the File sink version 4?

According to the blog post by @nblumhardt at https://nblumhardt.com/2017/10/serilog-file-logging/ :

An early design decision — to split the primitive Serilog.Sinks.File sink from the Serilog.Sinks.RollingFile sink built on top of it — stood in the way of implementing some of the most-requested features, rolling on file size being the most obvious example. So, we’re changing direction and effectively merging these two packages into a single codebase with Serilog.Sinks.File version 4.0.0.

@mivano
Copy link
Contributor

mivano commented Jan 18, 2018

No concrete plans, but it can certainly be improved. See also datalust/serilog-sinks-seq#51 (comment)
Care for some PR?

@mivano
Copy link
Contributor

mivano commented Dec 16, 2019

Old issue, cleaning up. PR has been merged.

@mivano mivano closed this as completed Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants