chore: remove node6 support and upgrade codebase #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use async functions - use Object.entries/Object.values - use Object spreading BREAKING: bindings now use async functions so they’ll never throw, only reject
reconbot
force-pushed
the
reconbot/remove-node6
branch
from
d0e16ec to
629bc09
Compare
icebob
reviewed
Aug 12, 2019
| if (!command) { | ||
| return Promise.resolve(port); | ||
| port |
There was a problem hiding this comment.
Here is not missing a return?
There was a problem hiding this comment.
you're probably right, pr?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING: bindings now use async functions so they’ll never throw, only reject