From d4f5128026cf6b9e5beaea19316ecd2c3221cfa7 Mon Sep 17 00:00:00 2001 From: Francis Gulotta Date: Sun, 30 Dec 2018 22:58:29 -0500 Subject: [PATCH] fix: prebuild on mojave (#1759) OSX Mojave has issues building for node 6. Prebuild tries to build for everything we support and that includes node 6. Node 6 was built with `libstdc++` and osx has (over the past few years, along with nodejs core) moved to `libc++` as the standard library. It no longer supports it with xcode 10 and that's what ships with Mojave. References - Workaround until we drop node 6 https://github.com/nodejs/node/pull/23685#issuecomment-430408541 - More background https://github.com/nodejs/node/issues/24648 I reformatted trying to work around this issue. Glad it's solved. --- packages/bindings/binding.gyp | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/bindings/binding.gyp b/packages/bindings/binding.gyp index a085d2138..1afae4bf1 100644 --- a/packages/bindings/binding.gyp +++ b/packages/bindings/binding.gyp @@ -29,6 +29,7 @@ 'src/darwin_list.cpp' ], 'xcode_settings': { + 'MACOSX_DEPLOYMENT_TARGET': '10.9', 'OTHER_LDFLAGS': [ '-framework CoreFoundation -framework IOKit' ]