Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to run for external contributors #285

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Update CI to run for external contributors #285

merged 1 commit into from
Nov 26, 2023

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Nov 25, 2023

push only works for pushes to branches in the repository which means pull requests from forks won't trigger it.

This change limits the workflow running on push to the main branch, meaning everyone including maintainers with write access to this repository will now need to open a PR to have CI run but this is generally fine if you're already following a PR based flow (which most people do), and avoids running the workflow twice for PRs (once for the push trigger and then again for the pull_request trigger) which is a little nicer on 🌎

@sergiodxa sergiodxa changed the title ci: update CI to run for external contributors Update CI to run for external contributors Nov 26, 2023
@sergiodxa sergiodxa merged commit 3c1ded8 into sergiodxa:main Nov 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants