Add component to treat anchors as client side navigation #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-sherman
commented
Feb 19, 2023
| ref.current?.addEventListener( | ||
| "click", | ||
| (event) => { | ||
| const target = (event.target as Partial<HTMLElement>).closest?.("a"); |
There was a problem hiding this comment.
Browser support for closest is pretty good but not perfect. Is it ok to use or should I replace with a manual parent search?
There was a problem hiding this comment.
Compared it to ESM support it has a better support, so it should work on any Remix app.
sergiodxa
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
<TreatAnchorsAsClientSideNavigation>component that treats all<a>descendants with internal hrefs as if they were<Link>elements.This allows you to opt into this behaviour scoped to just a portion of your app.