Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note suggesting to use <Suspense> instead of <ClientOnly> #159

Merged
merged 2 commits into from
Feb 3, 2023
Merged

Add note suggesting to use <Suspense> instead of <ClientOnly> #159

merged 2 commits into from
Feb 3, 2023

Conversation

tom-sherman
Copy link
Contributor

@tom-sherman tom-sherman commented Feb 2, 2023 •
edited
Loading

I think the end goal should be to deprecate ClientOnly, but that would require a couple of things:

  • Wide enough adoption of React 18 and streaming SSR in remix apps (haven't researched this)
  • Better error handling. Right now this suspense technique logs the error on the server, which isn't ideal for Remix client-only components.

@tom-sherman tom-sherman changed the title Add note suggesitng to use <Suspense> instead of ClientOnly Add note suggestng to use <Suspense> instead of ClientOnly Feb 2, 2023
@tom-sherman tom-sherman mentioned this pull request Feb 2, 2023
Closed
@sergiodxa sergiodxa changed the title Add note suggestng to use <Suspense> instead of ClientOnly Add note suggesting to use <Suspense> instead of <ClientOnly> Feb 3, 2023
sergiodxa
sergiodxa reviewed Feb 3, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@sergiodxa sergiodxa added the documentation Improvements or additions to documentation label Feb 3, 2023
@sergiodxa sergiodxa merged commit 63dd329 into sergiodxa:main Feb 3, 2023
@linear linear bot mentioned this pull request Aug 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiodxa sergiodxa sergiodxa approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tom-sherman @sergiodxa