Fixed name of the temperature parameter #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha good catch, thanks a lot, there should be a better way of doing this, it shouldn't just fail silently with a default value... Thank your for the contribution, looking good! |
|
What if you removed the default values from the API? Or is the API intended for use outside of the current front-end? |
|
Yeah some people use the API outside of the front-end to build their own tools on top of Serge... I think some better type safety on the frontend would be a good addition, I'll need to have a look 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name of the parameter is
temperaturein the API, but this form passes it astemp, so all invocations ofllamaalways use a temperature of 0.1 (the default value in the API) regardless of this setting.