From 8000da6d9a9ed0fa1d09f313dfab14c6ce64aa34 Mon Sep 17 00:00:00 2001 From: Kyle Simpson Date: Wed, 19 May 2021 10:17:29 +0100 Subject: [PATCH] Chore: Rewrite update pathway. I had written this out before, but evidently it was lost somehow. This should fill in most of what was lost. --- CHANGELOG.md | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 55a118aca..2f48eb2e4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -16,7 +16,14 @@ Thanks to the following for their contributions: ### Upgrade Pathway * References to `songbird::{opus, Bitrate};` should now use `songbird::driver::{opus, Bitrate};`. -* Custom `Inputs` (i.e., `Reader::Extension`) +* Custom `Inputs` (i.e., `Reader::Extension`/`ExtensionSeek`) now need to implement `input::reader::MediaSource` rather than just `Read` and/or `Seek`. + * Sources which do not support seeking should have an `unreachable!()` function body or always return an error, as `MediaSource::is_seekable()` is used to gate support. +* Many event handler types in `songbird::EventContext` have changed to unit `enum`s, rather than `struct` variants. + * New body types are included in `songbird::events::context_data::*`. +* `Config` structs have been made non-exhaustive; they should be initialised via `Config::default()`. +* Channel join operations may now timeout after a default 10s—which *should* be handled. +* Errors returned when joining a channel will now inform you whether you should try to `leave` a channel before rejoining. +* Youtube-dl variants of `songbird::input::error::Error` have had their case altered from `DL` -> `Dl`. ### Added