Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you dynamically update the pickle file? #942

Closed
ntnz opened this issue Dec 31, 2023 · 1 comment
Closed

Can you dynamically update the pickle file? #942

ntnz opened this issue Dec 31, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@ntnz
Copy link

ntnz commented Dec 31, 2023

In my implementation I'm dynamically updating the facial database fairly often. When running find(), I think it warns me to delete the pickle each time I add to the database:

⚠️  Representations for images in <PATH> folder were previously stored in representations_vgg_fae.pkl. If you added new instances after the creation, then please delete this file and call find function again. It will create it again.

Doing this means the next time the database is used, it regenerates the pickle, which seems resource intensive.

Is there a way to dynamically update the pickle instead of regenerating the entire thing each time?

@serengil
Copy link
Owner

serengil commented Jan 1, 2024

Cons of updating pickle instead of re-create is that if an image is updated with same name, then we will still use its old embedding. That is why, I prefer to expect user to delete that pickle manually.

@serengil serengil closed this as completed Jan 1, 2024
@serengil serengil added the enhancement New feature or request label Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants