Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary size increase after #1107 (serde_json v1.0.112) #1114

Closed
jbourassa opened this issue Feb 28, 2024 · 1 comment
Closed

Binary size increase after #1107 (serde_json v1.0.112) #1114

jbourassa opened this issue Feb 28, 2024 · 1 comment

Comments

@jbourassa
Copy link

#1107 which is included in serde_json v1.0.112 added ~9kb to Wasm binaries.

Here's a reproduction repo that has Wasm files & code for 111 vs 112: https://github.com/jbourassa/tmp-serde-112-bin-increase

I understand that serde isn't optimizing for binary size; so maybe that's an acceptable tradeoff for better error messages. If that's the case, feel free to close this issue. Unclear to me how to improve it, but if you have ideas, I'm happy to take as stab at it.

@jbourassa
Copy link
Author

I got it wrong, 112 is actually smaller 🤦 . Not sure where my head was at, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant