Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum supported Go version to 1.21 #548

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Oct 4, 2024

Latest aws-sdk-go-v2 requires Go 1.21 or later

@at-wat at-wat self-assigned this Oct 4, 2024
@at-wat at-wat requested review from a team, 8823-scholar and ph-piment and removed request for a team October 4, 2024 04:25
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.39%. Comparing base (24314bb) to head (a66f45e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #548   +/-   ##
=======================================
  Coverage   65.39%   65.39%           
=======================================
  Files          33       33           
  Lines        1959     1959           
=======================================
  Hits         1281     1281           
  Misses        584      584           
  Partials       94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@ph-piment ph-piment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!
こちらと同様の修正であることを確認しました!!

@at-wat at-wat merged commit 33ce0f4 into master Oct 4, 2024
7 checks passed
@at-wat at-wat deleted the update-minimum-supported-go-version-to-1.21 branch October 4, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants