Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Receive *aws.Config on NewDialer #295

Merged
merged 3 commits into from
Jul 5, 2021
Merged

Receive *aws.Config on NewDialer #295

merged 3 commits into from
Jul 5, 2021

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Jul 3, 2021

No description provided.

@at-wat at-wat self-assigned this Jul 3, 2021
@codecov
Copy link

codecov bot commented Jul 3, 2021 •
edited
Loading

Codecov Report

Merging #295 (0071d8b) into master (b1c60a0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #295   +/-   ##
=======================================
  Coverage   63.51%   63.51%           
=======================================
  Files          32       32           
  Lines        1683     1683           
=======================================
  Hits         1069     1069           
  Misses        520      520           
  Partials       94       94
Impacted Files Coverage Δ
dialer.go 48.80% <ø> (ø)
presigner/presign.go 77.77% <ø> (ø)
tunnel/cmd/secure-tunnel-server/app.go 81.73% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1c60a0...0071d8b. Read the comment docs.

@at-wat at-wat requested a review from a team July 3, 2021 03:59
@at-wat
Copy link
Member Author

at-wat commented Jul 3, 2021

@seqsense/cloud_backend please take a look

kamatama41
kamatama41 approved these changes Jul 5, 2021
View reviewed changes
Copy link
Contributor

@kamatama41 kamatama41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙆‍♂️

@at-wat at-wat merged commit 02c157e into master Jul 5, 2021
@at-wat at-wat deleted the receive-aws-config-ptr branch July 5, 2021 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamatama41 kamatama41 kamatama41 approved these changes

Assignees

@at-wat at-wat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@at-wat @kamatama41