Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move job failure messages into separate, hash-based keys #14

Open
bkirz opened this issue Apr 16, 2013 · 0 comments
Open

Move job failure messages into separate, hash-based keys #14

bkirz opened this issue Apr 16, 2013 · 0 comments

Comments

@bkirz
Copy link
Contributor

bkirz commented Apr 16, 2013

qless-core currently stores a job's failure message as part of its data. For the most worker types, this means all failed jobs have exception backtraces and messages in their job data. We've seen thousands of jobs fail with identical failure messages, which bloats our memory usage considerably. Additionally, these keys never expire, so the only way to prevent running out of memory is to handle these errors manually.

I discussed this with @myronmarston, and we came up with a few changes we can make to solve this problem:

  • Move job failure messages into separate keys with their own expirations. That way, jobs that fail won't be dropped on the floor, but they won't use up nearly as much memory indefinitely.
  • Key the job failure messages by the hash of the message. This handles the duplicate error message issue.

What do you think, @dlecocq?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant