Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate possibility of housing "grpc-web" generated stubs in this project #14

Open
arawinters opened this issue Feb 11, 2025 · 0 comments
Assignees
Labels
V4 To be delivered in V4

Comments

@arawinters
Copy link
Contributor

It might make sense to house the sz-sdk-typescript-grpc-web logic in this repo. As far as I can tell the class implementation code is identical to the non web grpc implementation(s), just with different class names and client stubs. There might be a way to abstract the base classes or use a method factory and not have to manage two separate codebases that share 90% of their code.

maybe YES, maybe NO.

@arawinters arawinters added the V4 To be delivered in V4 label Feb 11, 2025
@arawinters arawinters self-assigned this Feb 11, 2025
@github-actions github-actions bot added the triage Need to triage label Feb 11, 2025
@jamietypovsky jamietypovsky removed the triage Need to triage label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V4 To be delivered in V4
Projects
None yet
Development

No branches or pull requests

2 participants