Check erroneously shown as silenced in client view

[cwjohnston]

Expected Behavior

In the client and event views, Uchiwa should only show a check as silenced if it is actually silenced for that client.

Current Behavior

Checks are shown as silenced in client and event views when a check and one or more of its defined subscriptions match a silencing entry, even though silencing entry does not match the selected client.

Steps to Reproduce (for bugs)

1. Define a failing check check_foo with subscribers foo, bar, baz
2. Define a client with subscriptions bar, baz
3. Create a silencing entry for foo:check_foo
4. Observe that check_foo is shown as silenced in the client and event views, even though the client subscriptions do not match the silencing entry.

Context

Check results which generate alerts despite appearing silenced via the dashboard create confusion. 🙃

Your Environment

• Uchiwa version used: 1.1.1-1
• Sensu version used: 1.2.0
• Operating System and version (e.g. Ubuntu 14.04): Centos 7