Skip to content
This repository has been archived by the owner on Jan 7, 2020. It is now read-only.

feature request: re-add iFrame support.. #354

Closed
roobert opened this issue Jul 12, 2015 · 3 comments
Closed

feature request: re-add iFrame support.. #354

roobert opened this issue Jul 12, 2015 · 3 comments
Milestone

Comments

@roobert
Copy link
Contributor

roobert commented Jul 12, 2015

Hi Palourde,

I was just reimplementing embedded graphs (this time with grafana) when I noticed uchiwa-web no-longer supports iframes. Here was my original PR that got merged: 6cde2ec

Is there any reason it was removed?

I would also be grateful for ideas on allowing an ID or class to be set for each iframe. As mentioned in the PR I thought simply changing the syntax for the field to be something like: "iframe:[id]:[url]" might work. It would be nice if Uchiwa could be configured, or could look for a local css file, too. What do you think?

Cheers,

@palourde
Copy link
Contributor

@roobert My bad! I'll look into this ASAP.

@roobert
Copy link
Contributor Author

roobert commented Jul 14, 2015

@palourde: any comment on adding an id or class for custom styling..?

@palourde palourde added this to the 0.10.2 milestone Jul 24, 2015
@palourde
Copy link
Contributor

@roobert You now have a span with iframe class that contains the actual iframe.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants