Sensu_client_config and subscriptions are always retriggered at every puppet run, leading to no-checks being run under certain circumstances

[stefanandres]

Even though the client_config and subscriptions are properly set (the json is written), puppet always re-writes it in every run.
Those providers also notify the sensu-client so it will restart. That leads to endless restarting if you have puppet running with noop = false every minute.
If you run puppet every minute with noop = false then all checks with interval < 60 will never get checked because sensu-client restarts before even one check is getting executed.

Notice: /Stage[main]/Sensu::Client::Config/Sensu_client_config[$client_name]/ensure: created

[stefanandres]

Ah, in https://github.com/sensu/sensu-puppet/blob/v1.0.0/lib/puppet/provider/sensu_client_config/json.rb#L19 you can see the file is hard coded and in master it is defined as method and it probably it not initiated there yet: https://github.com/sensu/sensu-puppet/blob/master/lib/puppet/provider/sensu_client_config/json.rb#L19

702c75b is the commit that breaks it.

[stefanandres]

https://github.com/stefanandres/sensu-puppet/commit/1f1f58d4c5c7a19b9fa05ac24df7ee15250d1d1c workarounds that issue for me (used wrong file name in the first run, https://github.com/stefanandres/sensu-puppet/commit/0b59096ca4917d230aea3da1b255c624211bd043 is also needed), but it should get fixed upstream properly.

[stefanandres]

#224 fixed it.