Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset integrity testing #5

Open
calebhailey opened this issue Jan 27, 2021 · 2 comments
Open

Asset integrity testing #5

calebhailey opened this issue Jan 27, 2021 · 2 comments
Labels
component:tests CI tests for SensuFlow enhancement New feature or request
Milestone

Comments

@calebhailey
Copy link

Fetch and verify every asset URL+SHA512 pair. Fail if any URL is unreachable, or if a SHA512 doesn't match.

@calebhailey calebhailey added enhancement New feature or request component:tests CI tests for SensuFlow labels Jan 27, 2021
@calebhailey calebhailey added this to the Release 0.5.0 milestone Jan 27, 2021
@jspaleta
Copy link
Contributor

pretty straight forward... but potentially expensive.
Do we want to separate flag to disable this, instead of just the global DISABLE_SANITY_CHECKS flag?

I can see wanting to skip this on merge, but having it on for pull requests, but checking this for every merge is a lot of download churn.

@calebhailey
Copy link
Author

Yes, I'd say we'll want somewhat granular toggles for enabling/disabling various tests; and some defaults around which tests are run on PRs vs commits to main, etc.

@jspaleta jspaleta modified the milestones: Release 0.5.0, Release 0.6.0 Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:tests CI tests for SensuFlow enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants