Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] filesystem cat broken with last commit (missing should_download_folder) #716

Open
lisbonresearch opened this issue Jan 31, 2025 · 1 comment
Labels
freshissue Default label for new, untriaged issues.

Comments

@lisbonresearch
Copy link

The command filesystem cat fails on iOS with:

TypeError: _download_ios() missing 1 required positional argument: 'should_download_folder'

The latest commit introduced a new positional argument to this method, which is not being passed on the call on line 734

Note: probably the line 737 which calls _download_android has a similar issue.

@lisbonresearch lisbonresearch added the freshissue Default label for new, untriaged issues. label Jan 31, 2025
@lisbonresearch lisbonresearch changed the title [bug] Bug Description Here [bug] filesystem cat broken with last commit (missing should_download_folder) Jan 31, 2025
@IPMegladon
Copy link
Collaborator

Thanks, I have spotted this while looking at other things. Not sure why this part did not get committed. Granted that commit was actually not intended to go direct to main. Will do a fix after the other PR's are merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
freshissue Default label for new, untriaged issues.
Projects
None yet
Development

No branches or pull requests

2 participants