Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type Exception Handling for the Mail Helper #816

Closed
thinkingserious opened this issue Oct 20, 2018 · 3 comments
Closed

Type Exception Handling for the Mail Helper #816

thinkingserious opened this issue Oct 20, 2018 · 3 comments
Labels
difficulty: hard fix is hard in difficulty type: twilio enhancement feature request on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

Issue Summary

The appropriate types necessary for a successful mail/send API call is documented here. We want to throw a type exception when the wrong type is provided.

Acceptance Criteria

  • All parameters for the mail\send endpoint are type checked and if they fail the type check and exception is thrown with instructions on how to fix
@thinkingserious thinkingserious added difficulty: hard fix is hard in difficulty hacktoberfest status: help wanted requesting help from the community type: twilio enhancement feature request on Twilio's roadmap labels Oct 20, 2018
@alexhoffman617
Copy link

alexhoffman617 commented Oct 23, 2018 •
edited
Loading

@thinkingserious I was taking a look at picking this up, but it seems like this functionality already exists. When I run a request with an improper subject i get: UnhandledPromiseRejectionWarning: Error: String expected for subject... What would be the expected behavior after this fix?

@ghost ghost mentioned this issue Oct 25, 2018
Closed
6 tasks
@ghost
Copy link

ghost commented Oct 25, 2018

@alexhoffman617 Some of them do already have validation, but it's not consistent across fields. For example, the subject field is validated on creation, but the from field is not.

@thinkingserious thinkingserious added status: work in progress Twilio or the community is in the process of implementing and removed help wanted status: help wanted requesting help from the community labels Oct 30, 2018
@childish-sambino
Copy link
Contributor

Changes have been merged: 96f2c7a

@childish-sambino childish-sambino removed the status: work in progress Twilio or the community is in the process of implementing label Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: hard fix is hard in difficulty type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate field types sent to mail helper API
3 participants
@thinkingserious @alexhoffman617 @childish-sambino