Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Template support is missing from the TypeScript definitions #740

Closed
notheotherben opened this issue Sep 13, 2018 · 3 comments
Closed

Dynamic Template support is missing from the TypeScript definitions #740

notheotherben opened this issue Sep 13, 2018 · 3 comments
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: bug bug in the library

Comments

@notheotherben
Copy link
Contributor

Issue Summary

A user raised the issue that the new dynamic template functionality (and fields) are not represented in the TypeScript definitions for this project.

Specifically, it appears that the use case described in the mail package is not possible right now using TypeScript.

Steps to Reproduce

  1. Attempt to implement this use case in TypeScript.

Technical details:

  • sendgrid-nodejs Version: master (latest commit: 0c83ae9)
  • Node.js Version: 4.1.2
notheotherben referenced this issue Sep 13, 2018
@notheotherben
Add TypeScript definitions for v6 packages
a01a277
@thinkingserious
Copy link
Contributor

Hi @spartan563,

I think this is a related PR: #716

Thanks for opening this issue and getting the party started :)

With Best Regards,

Elmer

@thinkingserious thinkingserious added type: bug bug in the library status: help wanted requesting help from the community difficulty: medium fix is medium in difficulty labels Sep 18, 2018
@duncanleung
Copy link
Contributor

@thinkingserious the help wanted tag should be removed from this issue?

Looks like PR #716 adds in the fix to mail.d.ts and is just waiting to be merged.

@thinkingserious thinkingserious added status: work in progress Twilio or the community is in the process of implementing and removed status: help wanted requesting help from the community labels Oct 4, 2018
@thinkingserious
Copy link
Contributor

Thanks for the heads up @duncanleung!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: work in progress Twilio or the community is in the process of implementing type: bug bug in the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thinkingserious @notheotherben @duncanleung