Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is require('sendgrid-rest') repeated so much in /lib/sendgrid.js? #246

Closed
zacharynevin opened this issue Jun 20, 2016 · 5 comments
Closed
Labels
status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap

Comments

@zacharynevin
Copy link

Issue Summary

When looking through /lib/sendgrid.js, I noticed that require('sendgrid-rest') was placed everywhere. I'm fairly sure thats bad practice and that you should include it only once in the top of the file.

Technical details:

  • sendgrid-nodejs Version: master (latest commit: [commit number])
  • Node.js Version: 4.1.2
@thinkingserious
Copy link
Contributor

Hello @zacharynevin,

Thanks for the feedback!

I have tagged this issue for consideration for the next iteration of updates for this library. Any additional feedback/ideas/suggestions you may have is greatly appreciated!

With Best Regards,

Elmer

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: help wanted requesting help from the community labels Jun 20, 2016
@adamreisnz
Copy link
Contributor

@zacharynevin this is now addressed by #261
If you could +1 there that would be helpful for the Sendgrid team to push it through for merge.

@thinkingserious
Copy link
Contributor

@adambuczynski,

Thanks for relating this ticket :)

I've added the +1 on our side already.

@adamreisnz
Copy link
Contributor

Cheers thanks :)

@thinkingserious
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

No branches or pull requests

3 participants