Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breakup examples in examples/mailsettings/mailsettings.java to their own files #376

Closed
thinkingserious opened this issue Oct 30, 2017 · 2 comments
Closed

Breakup examples in examples/mailsettings/mailsettings.java to their own files #376

thinkingserious opened this issue Oct 30, 2017 · 2 comments
Labels
difficulty: easy fix is easy in difficulty status: help wanted requesting help from the community type: docs update documentation change not affecting the code

Comments

@thinkingserious
Copy link
Contributor

thinkingserious commented Oct 30, 2017 •
edited by mbernier
Loading

File mailsettings.java has 321 lines of code (exceeds 250 allowed). Consider refactoring.

Break up these examples into their own files, named after the action being shown.

https://codeclimate.com/github/sendgrid/sendgrid-java/examples/mailsettings/mailsettings.java#issue_59f6aee388b6810001000060
@mbernier mbernier changed the title Fix "file_lines" issue in examples/mailsettings/mailsettings.java Breakup examples in examples/mailsettings/mailsettings.java to their own files Oct 30, 2017
@mithunsasidharan
Copy link
Contributor

@mbernier : #373

@thinkingserious thinkingserious added status: help wanted requesting help from the community difficulty: easy fix is easy in difficulty up-for-grabs type: docs update documentation change not affecting the code labels Feb 28, 2018
@aleien
Copy link

aleien commented Oct 7, 2018

@thinkingserious
Seems like this one is resolved (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: help wanted requesting help from the community type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@thinkingserious @mithunsasidharan @aleien @childish-sambino