Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "file_lines" issue in examples/user/user.java #326

Closed
thinkingserious opened this issue Oct 27, 2017 · 1 comment · Fixed by #370
Closed

Fix "file_lines" issue in examples/user/user.java #326

thinkingserious opened this issue Oct 27, 2017 · 1 comment · Fixed by #370
Labels
difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

thinkingserious commented Oct 27, 2017 •
edited by mbernier
Loading

File user.java has 422 lines of code (exceeds 250 allowed). Consider refactoring.

Take each of the examples and make them their own file.
Then create a README file that links to each example.

https://codeclimate.com/github/sendgrid/sendgrid-java/examples/user/user.java#issue_59f382f3ba92590001000052
@mbernier mbernier added good first issue difficulty: easy fix is easy in difficulty labels Oct 27, 2017
@adamsau
Copy link
Contributor

adamsau commented Oct 28, 2017

I will work on this issue~

@adamsau adamsau mentioned this issue Oct 29, 2017
Merged
@thinkingserious thinkingserious added status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap and removed good first issue labels Feb 28, 2018
@childish-sambino childish-sambino removed the status: work in progress Twilio or the community is in the process of implementing label Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: breakup examples to their own files in examples/user/user.java adamsau/sendgrid-java
4 participants
@thinkingserious @mbernier @adamsau @childish-sambino