Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsDigraph method for LatticeOfCongruences #369

Closed
james-d-mitchell opened this issue Sep 1, 2017 · 2 comments
Closed

AsDigraph method for LatticeOfCongruences #369

james-d-mitchell opened this issue Sep 1, 2017 · 2 comments
Assignees
@mtorpey
Labels
newcomer-friendly A label for issues that are good for first time contributors.

Comments

@james-d-mitchell
Copy link
Collaborator

It would be helpful to have an AsDigraph method for the object returned by LatticeOfCongruences. This can be obtained by doing

DigraphReflexiveTransitiveClosure(Digraph(AsList(LatticeOfCongruences(S))));

which is a bit long.

As I'm writing this, I am wondering why the return value of LatticeOfCongruences isn't a digraph anyway, with the vertices labelled by the congruences themselves. Maybe there is a good reason that this is not done, but I can't think what it is. Any comments @mtorpey?
@james-d-mitchell james-d-mitchell added 3.0 newcomer-friendly A label for issues that are good for first time contributors. labels Sep 1, 2017
@wilfwilson
Copy link
Collaborator

I like this idea.

@mtorpey
Copy link
Collaborator

mtorpey commented Sep 1, 2017 •
edited
Loading

I like this idea too! I'll implement it next week in 19 days.

@mtorpey mtorpey self-assigned this Sep 13, 2017
This was referenced Sep 20, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mtorpey mtorpey

Labels
newcomer-friendly A label for issues that are good for first time contributors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mtorpey @james-d-mitchell @wilfwilson