Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

since keytar was removed, fails to prompt for CircleCI API token when it should #277

Open
jedwards1211 opened this issue May 22, 2019 · 0 comments · May be fixed by #278
Open

since keytar was removed, fails to prompt for CircleCI API token when it should #277

jedwards1211 opened this issue May 22, 2019 · 0 comments · May be fixed by #278
Labels
cli

Comments

@jedwards1211
Copy link
Contributor

the existing when logic for the CircleCI token input is the only thing referring to the ask-for-passwords option anymore, which defaults to false, hence by default it doesn't prompt for the token and all we see is an error following repo on CircleCI! message. I think @gr2m put that logic in there by mistake, AFAIK it should always be prompting for the token.
@jedwards1211 jedwards1211 linked a pull request May 22, 2019 that will close this issue
Open
@pvdlg pvdlg added the cli label Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(circle): always prompt for CircleCI API token jedwards1211/semantic-release-cli
2 participants
@jedwards1211 @pvdlg