Skip to content

Commit

Permalink
[dotnet] remove download url parameter from driver service constructor
Browse files Browse the repository at this point in the history
nothing is done with this parameter and users passing in a value should get an error rather than having it be ignored
  • Loading branch information
titusfortner committed Jan 30, 2024
1 parent e7fb98b commit 4dc45f7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions dotnet/src/webdriver/Chromium/ChromiumDriverService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ public abstract class ChromiumDriverService : DriverService
/// <param name="executablePath">The full path to the ChromeDriver executable.</param>
/// <param name="executableFileName">The file name of the ChromeDriver executable.</param>
/// <param name="port">The port on which the ChromeDriver executable should listen.</param>
/// <param name="downloadUrl">The URL from which the driver executable can be downloaded.</param>
protected ChromiumDriverService(string executablePath, string executableFileName, int port, Uri downloadUrl = null)
protected ChromiumDriverService(string executablePath, string executableFileName, int port)
: base(executablePath, port, executableFileName)
{
}
Expand Down
3 changes: 1 addition & 2 deletions dotnet/src/webdriver/DriverService.cs
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,13 @@ public abstract class DriverService : ICommandServer
/// <param name="servicePath">The full path to the directory containing the executable providing the service to drive the browser.</param>
/// <param name="port">The port on which the driver executable should listen.</param>
/// <param name="driverServiceExecutableName">The file name of the driver service executable.</param>
/// <param name="driverServiceDownloadUrl">This parameter is no longer used; kept for backwards compatibility.</param>
/// <exception cref="ArgumentException">
/// If the path specified is <see langword="null"/> or an empty string.
/// </exception>
/// <exception cref="DriverServiceNotFoundException">
/// If the specified driver service executable does not exist in the specified directory.
/// </exception>
protected DriverService(string servicePath, int port, string driverServiceExecutableName, Uri driverServiceDownloadUrl = null)
protected DriverService(string servicePath, int port, string driverServiceExecutableName)
{
this.driverServicePath = servicePath;
this.driverServiceExecutableName = driverServiceExecutableName;
Expand Down

0 comments on commit 4dc45f7

Please sign in to comment.