Skip to content

Check errors on setting non-scalars #52

Merged
merged 3 commits into from
Nov 13, 2018
Merged

Conversation

ozerovandrei
Copy link
Contributor

@ozerovandrei ozerovandrei commented Oct 15, 2018

Check error on setting servers and all_quotas attributes in selvpc_resell_floatingip_v2, selvpc_resell_license_v2 and selvpc_resell_project_v2 resources.

Depends on #48
For #47

@ozerovandrei
Copy link
Contributor Author

@bill-rich this is ready for review.
This PR depends on #48.

@bill-rich bill-rich mentioned this pull request Oct 15, 2018
8 tasks
@ozerovandrei ozerovandrei force-pushed the fix/errors-for-non-scalars branch from 6f05022 to 619f778 Compare October 15, 2018 11:28
@ozerovandrei ozerovandrei force-pushed the fix/errors-for-non-scalars branch 3 times, most recently from 6959c1c to 69d81d5 Compare November 7, 2018 04:13
Check error on setting non-scalar attribute.
Check error on setting non-scalar attribute.
Check error on setting non-scalar "all_quotas" and "theme" attributes.
@ozerovandrei ozerovandrei force-pushed the fix/errors-for-non-scalars branch from 69d81d5 to b99839e Compare November 8, 2018 08:34
@ozerovandrei
Copy link
Contributor Author

@bill-rich this is rebased from latest master and ready.

Copy link

@bill-rich bill-rich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ozerovandrei ozerovandrei merged commit 9a2291b into master Nov 13, 2018
@ozerovandrei ozerovandrei deleted the fix/errors-for-non-scalars branch November 13, 2018 22:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants