Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete or private the copy constructors for pcpp::Logger to prevent accidental copies. #1708

Open
Dimi1010 opened this issue Feb 6, 2025 · 0 comments · May be fixed by #1714
Open

Delete or private the copy constructors for pcpp::Logger to prevent accidental copies. #1708

Dimi1010 opened this issue Feb 6, 2025 · 0 comments · May be fixed by #1714
Labels
enhancement refactoring

Comments

@Dimi1010
Copy link
Collaborator

Dimi1010 commented Feb 6, 2025 •
edited
Loading 

auto logger = pcpp::Logger::getInstance(); //< auto does not deduce references. It should be auto&. An implicit copy is being made here.
logger.suppressLogs();

Originally posted by @Dimi1010 in #1706
@Dimi1010 Dimi1010 linked a pull request Feb 11, 2025 that will close this issue
Open
@Dimi1010 Dimi1010 linked a pull request Feb 11, 2025 that will close this issue
Marked Logger copy ctors as deleted. #1714
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Marked Logger copy ctors as deleted. Dimi1010/PcapPlusPlus
1 participant
@Dimi1010