Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

500 response on bogus operation parameter #88

Closed
dbyron0 opened this issue Jun 18, 2018 · 1 comment
Closed

500 response on bogus operation parameter #88

dbyron0 opened this issue Jun 18, 2018 · 1 comment

Comments

@dbyron0
Copy link

dbyron0 commented Jun 18, 2018

One of the calls to getOperation in ScepServlet.java is wrapped in a try/catch block looking for IllegalArgumentException. Unfortunately there's an earlier call in getMessageBytes that isn't. As a result, when hitting the servlet with a bogus operation parameter, the response has status code 500 from the unhandled exception, instead of 400 with the Invalid "operation" parameter response body.

@dbyron0
Copy link
Author

dbyron0 commented Jun 18, 2018

See #88 for a crack at fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants