You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
TableRow uses innerRef, but when using the is prop, you might not have a component that supports ref.
The Link component from react-router actually implements the same innerRef API as in ui-box/ Evergreen. In this case TableRow gets a ref that is actually a React component. As we are trying to assist focus management with things such as this.mainRef.blur things start to break
That seems asking for problems, but might solve this use case
The other way could be to make sure we are dealing with a real element in TableRow — and other components that make the assumption of seeing a element.
There might be some ways we could use the new React.forwardRef to help with this problem.
The text was updated successfully, but these errors were encountered:
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Culprit
evergreen-v4/esm/table/src/TableRow in apply
TableRow uses
innerRef
, but when using theis
prop, you might not have a component that supportsref
.The
Link
component fromreact-router
actually implements the sameinnerRef
API as inui-box
/Evergreen
. In this caseTableRow
gets aref
that is actually a React component. As we are trying to assist focus management with things such asthis.mainRef.blur
things start to breakThere are a couple of things we could do:
That seems asking for problems, but might solve this use case
The other way could be to make sure we are dealing with a real element in
TableRow
— and other components that make the assumption of seeing a element.There might be some ways we could use the new
React.forwardRef
to help with this problem.The text was updated successfully, but these errors were encountered: