Skip to content
This repository has been archived by the owner on Mar 17, 2024. It is now read-only.

Support for custom / additional labels #34

Closed
dpoldrugo opened this issue Jul 17, 2019 · 3 comments · Fixed by #61
Closed

Support for custom / additional labels #34

dpoldrugo opened this issue Jul 17, 2019 · 3 comments · Fixed by #61
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dpoldrugo
Copy link

dpoldrugo commented Jul 17, 2019

It would be great to have a possibility to specify custom / additional labels which could be specified per cluster.

Example:

kafka-lag-exporter {
  port = 9999
  lookup-table-size = 60
  clusters = [
    {
      name = "us-east_ny_a-cluster"                                   
      bootstrap-brokers = "us-east_ny_a-1.cluster-a.xyzcorp.com:9092,us-east_ny_a-2.cluster-a.xyzcorp.com:9092,us-east_ny_a-3.cluster-a.xyzcorp.com:9092"
      labels {
        location = "ny"
        zone = "us-east"
      }
    }
  ]
}

And this should add to all metrics for this cluster those two labels with given values.

This would simplify the Prometheus job config. Because now Prometheus relabelling tricks must be applied to get this labels.

@seglo
Copy link
Owner

seglo commented Jul 18, 2019

Thanks for trying the project, @dpoldrugo. I can see how that would be useful. I'll add it to the backlog. Let me know if this is something you would consider contributing.

@seglo seglo added enhancement New feature or request good first issue Good for newcomers labels Jul 18, 2019
@anbarasantr
Copy link
Contributor

I would like to pick this up @seglo

@seglo
Copy link
Owner

seglo commented Sep 9, 2019

@anbarasantr Excellent. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants