Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atom-text-editor.Object.defineProperty.get is deprecated. #7

Open
michaeloboyle opened this issue Feb 15, 2017 · 5 comments
Open

atom-text-editor.Object.defineProperty.get is deprecated. #7

michaeloboyle opened this issue Feb 15, 2017 · 5 comments

Comments

@michaeloboyle
Copy link

The contents of atom-text-editor elements are no longer encapsulated
within a shadow DOM boundary. Please, stop using shadowRoot and access
the editor contents directly instead.

atom-text-editor.Object.defineProperty.get (/Applications/Atom.app/Contents/Resources/app.asar/src/text-editor-element.js:68:18)
setupPreviewer (/Users/moboyle/.atom/packages/diagrams/lib/diagrams.js:74:23)
textEditorObserverDisposable.atom.workspace.observeTextEditors (/Users/moboyle/.atom/packages/diagrams/lib/diagrams.js:36:13)
Workspace.observeTextEditors (/Applications/Atom.app/Contents/Resources/app.asar/src/workspace.js:329:9)
Object.activate (/Users/moboyle/.atom/packages/diagrams/lib/diagrams.js:35:60)
Package.activateNow (/Applications/Atom.app/Contents/Resources/app.asar/src/package.js:191:19)
@seflless
Copy link
Owner

Do I use that somewhere? I couldn't find it

@leino11121
Copy link

the same issue.

@seflless
Copy link
Owner

seflless commented Apr 4, 2017

@leino11121 Which OS, which version of the package, which version of Atom, any specific example file I can look at?

@Britz
Copy link

Britz commented May 30, 2017

Atom detects a deprecation in Diagrams

Deprecated calls

diagrams (1 deprecation)

The contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. Please, stop using shadowRoot and access the editor contents directly instead.

  • atom-text-editor.Object.defineProperty.get - /Applications/Atom.app/Contents/Resources/app/src/text-editor-element.js:68:18
  • setupPreviewer - /Users/USERNAME/.atom/packages/diagrams/lib/diagrams.js:74:23
  • textEditorObserverDisposable.atom.workspace.observeTextEditors - /Users/USERNAME/.atom/packages/diagrams/lib/diagrams.js:36:13
  • Workspace.observeTextEditors - :23077:15
  • Object.activate - /Users/USERNAME/.atom/packages/diagrams/lib/diagrams.js:35:60
  • Package.activateNow - :68279:25

Used with newest available versions of Atom (1.17.2) and Diagrams (0.26.4) on macOS Sierra (10.12.5).

@seflless
Copy link
Owner

Fixed in 0.28.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants