Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPU Boost dropdown updating bug #227

Closed
manciuszz opened this issue Apr 11, 2023 · 5 comments
Closed

CPU Boost dropdown updating bug #227

manciuszz opened this issue Apr 11, 2023 · 5 comments

Comments

@manciuszz
Copy link

CPU Boost dropdown menu fails to update properly when cycling through profiles.

CPU_Boost_UI_Bug.mp4

@seerge
Copy link
Owner

seerge commented Apr 11, 2023

@manciuszz can you post your config.json here ?

@manciuszz
Copy link
Author

config.json

{
  "performance_mode": 0,
  "performance_1": 0,
  "gpu_mode": 1,
  "frequency": -1,
  "overdrive": 1,
  "aura_mode": 3,
  "aura_speed": 0,
  "gpu_auto": 0,
  "mid_fan": 0,
  "limit_total_1": 125,
  "limit_cpu_1": 80,
  "limit_total_2": 125,
  "limit_cpu_2": 80,
  "charge_limit": 80,
  "limit_total_0": 125,
  "limit_cpu_0": 80,
  "auto_boost_2": 2,
  "auto_boost_0": 3,
  "auto_apply_1": 0,
  "auto_apply_power_1": 0,
  "fan_rpm": 0,
  "scheme_0": "6d264563-183f-431a-ab92-f2607da30dba",
  "scheme_1": "30b7929b-a695-4451-8425-7ba3253260f4",
  "scheme_2": "2c01786e-b4e6-4b88-830e-b02a8104a168",
  "auto_boost_1": 2,
  "fan_profile_cpu_1": "14-3F-44-48-4C-50-54-62-11-1A-22-29-34-43-51-5A",
  "fan_profile_gpu_1": "14-3E-43-47-4C-50-53-62-16-22-2C-33-40-4A-58-5F"
}

@seerge
Copy link
Owner

seerge commented Apr 11, 2023

@manciuszz ok, looks like it's connected with a custom power plans i have added for you, i will push a fix tomorrow

@manciuszz
Copy link
Author

manciuszz commented Apr 11, 2023

Although this is not related to the bug, I don't want to create a new issue if I can help it.

EDIT:
After writing this block of text, I actually feel I should make a new issue as a feature request for this Q.Q


It would be nice to have an on hover (or on mouse down) tooltips inside the graph over each fan node.

At the moment we only see tooltips when we interact with a specific node, usually by dragging it 1 pixel. That's not very user friendly. It's pretty difficult to adjust nodes fast on first try using a HIGH DPI mouse :/
It also seems like the fan RPM's are being rounded up, so in this case, a more snappy or grid like graph would make more sense other than allowing free X / Y axis movement.

Furthermore, 'reset factory defaults' button affects both CPU and GPU fan profiles. What if a user doesn't want to touch his preconfigured CPU profile, but want to reset the GPU only? He's forced to reset both and redo everything again. Again, that's just bad user experience.

@seerge
Copy link
Owner

seerge commented Apr 12, 2023

GHelper.zip

  1. This build should set CPU Boost after switching power scheme, so it should work as intended (even tho you config may be messed and you may want to set boost settings for each profile again)
  2. Chart tip should appear every time you move mouse over a curve
  3. Reset factory defaults is done like that because how "technically" all those settings work :
  • app sets one of 3 predefined modes in bios
  • app sets fan curve (if selected)
  • app sets PPTs (if selected)

Reset - just sets predefined mode, without setting anything else.

@seerge seerge closed this as completed Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants