New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BaseVector to be independent of dimensionality and constructible? #35

Open

fwkoch opened this issue Mar 27, 2019 · 0 comments

Labels

Contributor

fwkoch commented Mar 27, 2019

From @Evelyn-H (see #34):

I feel like having the x, y, and now, rho and theta getters/setters as part of BaseVector is a bit counter-intuitive. Maybe having the BaseVector as a generic n-dimensional vector (that is also instantiable) that only has operations that work independently of the dimensionality - like it mostly is currently - could be useful.

It might even be possible to move (part of) the constructor to the BaseVector and make it easier for users to implement 4d vectors for example.
(And maybe it's even possible to merge the BaseVector and BaseVectorArray? I might be missing something - I'm pretty new to the codebase - but if it's possible it would remove a lot of code duplication)

fwkoch added the discussion label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment