This repository has been archived by the owner on Apr 8, 2024. It is now read-only.
feat(decorateClientConfig): Upgrade to version 4 #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades the decorators to support webpack v4. We have made it this far because most apps are running sku which handles this for you.
The primary change for consumers is around the handling of styles emitted from the style guide compilation. The client decorator now has a
cssOutputLoader
option allowing you to configure the final loader in the css pipeline.BREAKING CHANGE: Removed the client decorator option
extractTextPlugin
in favour ofcssOutputLoader
. Also upgrading from webpack 3 to 4 so any plugins/loaders would need to besupported by 4.
Migration Guide
Consumers will need to migrate their applications to support webpack v4, which will be project specific based on the webpack config.
Beyond the webpack upgrade, only consumers using the
extractTextPlugin
option in the client decorator need to migrate to the newcssOutputLoader
option. Theextract-text-webpack-plugin
is not supported in webpack 4, butmini-css-extract-plugin
is essentially a drop in replacement.