This repository has been archived by the owner on Apr 8, 2024. It is now read-only.
feat(index): Added plugin to strip flow types #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order for the style guide to support flow types going forward we'll need to strip the types during compliation.
tamoore
force-pushed
the
add-flow-stip-types
branch
from
b5eff21 to
b5d1f26
Compare
tamoore
requested review from
markdalgleish,
mattcompiles,
michaeltaranto,
georgespyropoulos,
jahredhope and
kosanna
georgespyropoulos
approved these changes
Feb 1, 2018
jahredhope
approved these changes
Feb 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In order to add flow type to the style guide we'd need to remove the types at compile time
We'll also need to convert the flowtype definitions to propTypes.
(conventionally via a babel transform plugin).
Approach
I have just added this here and currently it won't be stripping any types from the style guide as it doesn't have any. However, this is really a prerequisite for using flow types in that project so it'd be the first thing we'd need to add.