Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure when focusing to a section of the document, the heading is not blocked by anything (newspaper header is blocking now) #52

Open
SalvaZaraes opened this issue Nov 7, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@SalvaZaraes
Copy link

Description:
In the desktop app, the focus button (used to jump to a specific heading within a document) does not function as expected. Clicking it does not take the user to the designated heading.

Steps to Reproduce:
Open a document in reading mode on the desktop app.
Use the focus button to jump to a heading.

Expected Behavior:
Clicking the focus button should scroll the view to the specified heading within the document.

@ericvicenti
Copy link
Collaborator

I just fixed this on desktop- the focus button has been disabled but the block is highlighted and scrolls when you click it

4add0b5

@horacioh the one remaining problem is the scroll-to offset. If you have a newspaper header and you click on a short block from the outline, the block scrolls behind the header and can't be seen

@horacioh horacioh self-assigned this Nov 12, 2024
@horacioh horacioh added the bug Something isn't working label Nov 12, 2024
@horacioh horacioh changed the title Bug: Focus Button Does Not Work While Reading Document (Desktop App) Make sure when focusing to a section of the document, the heading is not blocked by anything (newspaper header is blocking now) Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants