Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update annotations to python 3.9 #887

Open
jku opened this issue Oct 8, 2024 · 1 comment · May be fixed by #894
Open

Update annotations to python 3.9 #887

jku opened this issue Oct 8, 2024 · 1 comment · May be fixed by #894

Comments

@jku
Copy link
Collaborator

jku commented Oct 8, 2024

#886 is merged so we could start using "new" annotations in the code base. Fixing this requires no securesystemslib knowledge but understanding Python annotation basics is required.

Python 3.9 allows annotations using standard library containers (so e.g. dict instead of typing.Dict). In practice this should work:

  • bump requires-python in pyproject.toml
  • run ruff check --fix --unsafe-fixes securesystemslib tests
  • review that changes made by ruff are sensible
  • make sure tox -e lint and tox -e test pass
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant