Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCPSigner: test all of the keytypes #492

Open
jku opened this issue Jan 11, 2023 · 0 comments
Open

GCPSigner: test all of the keytypes #492

jku opened this issue Jan 11, 2023 · 0 comments
Labels
tests Issues related to testing

Comments

@jku
Copy link
Collaborator

jku commented Jan 11, 2023

Current test code for the Google Cloud Platform Signer only uses one ecdsa-sha2-nistp256 key.

GCPSigner supports more keys: this has not really been tested though: I just wrote the mappings without creating anything except the two ecdsa keys. It would make sense to test these all. I'm not sure about testing all keys on every test run* but at least a manual test of all of them would make sense.

This requires:

  • Creating the keys on KMS using a keyscheme-based naming scheme, and configuring them for use from this project (I am currently an admin on the google cloud project but I could add someone else for this too)
  • building the gcp_ids in the test with knowledge of that naming scheme

*) I would rather keep the signing operation count fairly low on the Google Cloud KMS: not because it's expensive but because it allows me to easily set usage limits on those operations.

@lukpueh lukpueh added the tests Issues related to testing label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues related to testing
Projects
None yet
Development

No branches or pull requests

2 participants